From 45560483447dd737a63efc236b2be07fd0fc4347 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 11 Jun 2025 12:12:53 -0700 Subject: Fix an issue in extension override. (#7402) * Fix an issue in extension override. * Fix typo in comment. --- source/slang/slang-check-decl.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'source/slang/slang-check-decl.cpp') diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp index b56c3cb07..2865188b4 100644 --- a/source/slang/slang-check-decl.cpp +++ b/source/slang/slang-check-decl.cpp @@ -7545,7 +7545,9 @@ void SemanticsVisitor::checkExtensionConformance(ExtensionDecl* decl) .as(); auto targetType = getTargetType(m_astBuilder, declRef); - for (auto inheritanceDecl : decl->getMembersOfType()) + // Make a copy of inhertanceDecls first since `checkConformance` may modify decl->members. + auto inheritanceDecls = decl->getMembersOfType().toList(); + for (auto inheritanceDecl : inheritanceDecls) { checkConformance(targetType, inheritanceDecl, decl); } @@ -7596,7 +7598,7 @@ void SemanticsVisitor::checkAggTypeConformance(AggTypeDecl* decl) // just with `abstract` methods that replicate things? // (That's what C# does). - // Make a copy of inhertanceDecls firstsince `checkConformance` may modify decl->members. + // Make a copy of inhertanceDecls first since `checkConformance` may modify decl->members. auto inheritanceDecls = decl->getMembersOfType().toList(); for (auto inheritanceDecl : inheritanceDecls) { -- cgit v1.2.3